Ticket #162 (closed enhancement: fixed)

Opened 4 years ago

Last modified 2 years ago

Improve some rrdupdate error messages

Reported by: human Owned by: oetiker
Priority: minor Milestone:
Component: rrd_update Version:
Keywords: improve error messages Cc: he@…

Description

I've written a tool which uses rrdtool, and it uses stdout to send updates to an rrdupdate process which is started once per "go".

Sometimes I get "illegal attempt to update using time..." error messages. However, that message doesn't say which rrd archive this applies to, and because of the buffering of stdio, the message may appear long after the offending update has been written.

Therefore, it would be beneficial if rrdupdate included the file name of the impacted RRD database in the error messages. I'll attach below two diffs, one to 1.2.27, one to 1.3.0, where the latter is a bit clunky due to restructuring done between the two versions.

Attachments

patch-am-1.2.27 Download (661 bytes) - added by human 4 years ago.
Patch against 1.2.27
patch-am-1.3.0 Download (662 bytes) - added by human 4 years ago.
Updated patch for rrdtool 1.3.0

Change History

Changed 4 years ago by human

Patch against 1.2.27

Changed 4 years ago by human

Updated patch for rrdtool 1.3.0

comment:1 Changed 4 years ago by human

Updated the patch to 1.3.0 to not have a huge array on the stack but instead use strdup(), so that it's a little less clunky...

comment:2 Changed 4 years ago by oetiker

thanks, applied in r1441 anf r1442

comment:3 Changed 4 years ago by oetiker

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.

NOTE: The content of this website is accessible with any browser. The graphical design though relies completely on CSS2 styles. If you see this text, this means that your browser does not support CSS2. Consider upgrading to a standard conformant browser like Mozilla Firefox or Opera but also Apple's Safari or KDE's Konqueror for example. It may also be that you are looking at a mirror page which did not copy the CSS for this page. Or if some pictu res are missing, then the mirror may not have picked up the contents of the inc directory.