Ticket #177 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Segmentation fault when using VDEF with SHIFTed variables

Reported by: human Owned by: oetiker
Priority: major Milestone:
Component: rrd_graph Version: 1.3dev
Keywords: VDEF SHIFT Cc:

Description

Starting with version 1.2.28, using VDEF with SHIFTed variables can lead to segmentation faults:

DEF:lastweek=total.rrd:active:LAST:step=60:end=now-7d:start=end-1d DEF:calls=mach01.rrd:active:LAST SHIFT:lastweek:608400 VDEF:callmax=calls,MAXIMUM VDEF:lastweekmax=lastweek,MAXIMUM

$ /usr/local/rrdtool-1.2.28/bin/rrdcgi -f peak2.cgi DEBUG: start == 1220028960, end == 1220115600, end_orig == 1220115495, 361 steps DEBUG: start == 1220029080, end == 1220115540, end_orig == 1219510695, 71574149 steps Segmentation fault

In rrd_graph.c when vdef_calc() is called, 'end' is calculated according to the shifted time, but 'start' isn't adjusted.

Change History

comment:1 Changed 3 years ago by human

  • Owner changed from oettiker to oetiker

comment:2 Changed 3 years ago by oetiker

  • Status changed from new to closed
  • Resolution set to fixed

fixed in r1530. pleas test.

comment:3 Changed 3 years ago by human

  • Cc hokiel@… removed
Note: See TracTickets for help on using tickets.

NOTE: The content of this website is accessible with any browser. The graphical design though relies completely on CSS2 styles. If you see this text, this means that your browser does not support CSS2. Consider upgrading to a standard conformant browser like Mozilla Firefox or Opera but also Apple's Safari or KDE's Konqueror for example. It may also be that you are looking at a mirror page which did not copy the CSS for this page. Or if some pictu res are missing, then the mirror may not have picked up the contents of the inc directory.