Ticket #207 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

missing #include for utime() in rrd_open.c

Reported by: human Owned by: oetiker
Priority: major Milestone:
Component: misc Version: 1.3.8
Keywords: Cc: vincent@…

Description

In RRDtool 1.3.6, when both HAVE_MMAP and HAVE_BROKEN_MS_ASYNC are defined (e.g. under Mac OS X Tiger), the utime() function is called in rrd_open.c, but its prototype is not declared:

rrd_open.c: In function 'rrd_open':
rrd_open.c:167: warning: implicit declaration of function 'utime'
rrd_open.c:167: warning: nested extern declaration of 'utime'

To avoid this problem, a

#include <utime.h>

is needed.

Change History

comment:1 Changed 3 years ago by oetiker

  • Status changed from new to closed
  • Resolution set to fixed

thanks ... fix is in r1738.

comment:2 Changed 3 years ago by human

  • Status changed from closed to reopened
  • Resolution fixed deleted

When building on Win32 (VS2008) from source: rrdtool-1.3.8.tar.gz 19-May-2009 15:47 1.0M

Error 86 fatal error C1083: Cannot open include file: 'utime.h': No such file or directory c:\rrdtool-sdk\rrdtool-1.3.8\src\rrd_open.c 16 rrdlib

comment:3 Changed 3 years ago by human

  • Version changed from 1.3.6 to 1.3.8

comment:4 Changed 3 years ago by oetiker

is the call to utime necessary in the win32 port ?

comment:5 Changed 3 years ago by oetiker

I wrapped it in a conditional in r1809

comment:6 Changed 3 years ago by human

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.

NOTE: The content of this website is accessible with any browser. The graphical design though relies completely on CSS2 styles. If you see this text, this means that your browser does not support CSS2. Consider upgrading to a standard conformant browser like Mozilla Firefox or Opera but also Apple's Safari or KDE's Konqueror for example. It may also be that you are looking at a mirror page which did not copy the CSS for this page. Or if some pictu res are missing, then the mirror may not have picked up the contents of the inc directory.